Avoid state update when component is unmount

[Dot-H]

What

Hi 👋, this PR closes #54 and avoid unnecessary renders.

How

It replaces the useEffectAsync and fetchURL with a new useMountFetch hook and moves the link-related state management in the hook.

See this commit for the implementation of the hook.

useEffectAsync

This hook keeps the request state (response, loading, error) and wraps the call to ScraperWraper so that:

• The state is not updated if the component is unmounted
• The request is cancelled if the component is unmounted

Moreover, this hooks has a loading state set to true as default to avoid unnecessary render on mount (due to setting the loading state to true).

ReactTinyLink

Uses the useEffectAsync hook return values to manage its state. It passes a default value to the hook's response so that in case of error, the value of the component does not change and there is potentially less re-render inside the whole component (I did not profile, this is just an assumption).

After this PR, the components renders only two times. Against four before.

• The initial render
• The render when loading is done (error or success)

Extra

I took the liberty to add an example in the demo to show the removal of the link. If you want me to this can be removed 🙂

Of course I am open to the discussion and do not hesitate to ask me for changes. Thank you for your time !

[Dot-H]

Hi @winhtaikaung, any interest on this ? If not, do you mind if I make an open source project based on this repo just exposing the hook ?

[winhtaikaung]

Hi @winhtaikaung, any interest on this ? If not, do you mind if I make an open source project based on this repo just exposing the hook ?

Hi, @Dot-H sorry for late response, I ve looked through it and looks good to me will merge it and release it by tonight. I would love to invite you to this project as contributor if you dont mind.

[Dot-H]

Hi @winhtaikaung, no worries. Thanks for the review, I'd be please to be a contributor 🙂

[winhtaikaung]

@all-contributors please add @Dot-H for bug and code

[allcontributors]

@winhtaikaung

I've put up a pull request to add @Dot-H! 🎉