Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1.接入 ts 产物流程 2.引入@antfu/eslint 校验 #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

xuan-T
Copy link
Collaborator

@xuan-T xuan-T commented Feb 9, 2023

No description provided.

Copy link
Owner

@winixt winixt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup script 里面的脚本没加类型

@@ -3,11 +3,12 @@ import { basename, dirname } from 'path';
import { defaultDependencies } from './config';
import { Dependence } from './dependence';

export const SCRIPT_LANGUAGE = 'js'; // 枚举值: js、ts
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

既然是枚举,为啥写死的 js

props: Record<string, any>;
emit: any;
initData?: ComputedRef<any>;
onConfirm?: any;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不得至少搞个 function ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants