Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Dark theme #98

Closed
AndreyAkinshin opened this issue Jan 12, 2017 · 20 comments
Closed

Feature request: Dark theme #98

AndreyAkinshin opened this issue Jan 12, 2017 · 20 comments
Assignees

Comments

@AndreyAkinshin
Copy link

No description provided.

@dmex dmex self-assigned this Jan 15, 2017
@dmex
Copy link
Collaborator

dmex commented Jul 18, 2017

The theme-fixes branch has a dark theme but it's too early (and unstable) to use yet.

@AndreyAkinshin
Copy link
Author

@dmex, any progress?

@dmex
Copy link
Collaborator

dmex commented Jul 25, 2018

@AndreyAkinshin

The latest nightly includes a checkbox on the general options tab for enabling theme support. You can change the Graphs > 'use old colours' option at runtime for a light/dark theme.

Theme feedback and suggestions welcome 😄

@AndreyAkinshin
Copy link
Author

@dmex, awesome, thanks!

The System Information looks much better now. However, on my 4K monitor, the "System" and "CPU" labels look strange:

image

The "Options" page looks too contrast because of the "pure" white font color. It makes sense to find better text colors (e.g., around #A9B7C6):

image

Many windows have partial dark theme support. E.g., "Find Handles or DLLs" looks like this:

image

The main "Processes" tab doesn't support the dark theme at all.

Anyway, thanks for the initial support. Looking forward to trying the updates.

@dmex
Copy link
Collaborator

dmex commented Aug 14, 2018

However, on my 4K monitor, the "System" and "CPU" labels look strange

I've reported the issue to Microsoft since it's a recent issue with Windows 10:

Win8:
image

Win10-RS3:
image

DrawTextW on Windows 7 and Windows 8 both draw the text correctly but Windows 10... 🤔

The "Options" page looks too contrast because of the "pure" white font color. It makes sense to find better text colors (e.g., around #A9B7C6):

The padding/spacing between the text needs to be increased when using "pure" white colors but it's proving to be a problem with some controls. I think adding an options page for changing the theme colors and settings might be better?

Many windows have partial dark theme support.

Scrollbars and some other dialogs don't support dark themes. Microsoft fixed those issues on the next version of Windows 10 (releasing sometime next month or October) 👍

@yossizahn
Copy link
Contributor

Hi,
The "Show details for all processes" button should be desaturated when PH is running elevated. This doesn't happen when theme support is enabled.
image

@ferenczy
Copy link

ferenczy commented Dec 5, 2018

So how is it supposed to work? I have to Enable theme support on the General tab under the Options first, restart the application, enable Show advanced options on the same tab and then I can change individual colors on the Advanced tab? There are no themes yet (I mean sets of predefined colors), right?

Also, toolbar buttons are displayed without any icons when the theme support is enabled. Moreover, Find window, Find window and thread, Find window and kill and Show details for all processes also don't have any text so there's just an empty space:

image

Doesn't matter if I have default or modern icons, but in the Customize... dialog, they have proper icons.

@dmex
Copy link
Collaborator

dmex commented Dec 5, 2018

There are no themes yet (I mean sets of predefined colors), right?

You can toggle the dark mode by selecting the 'use old colours' option in the Options > Graphs settings window.

toolbar buttons are displayed without any icons when the theme support is enabled

It's a known issue that I haven't been able to find and fix yet 😢

The "Show details for all processes" button should be desaturated when PH is running elevated

The UAC icon comes from Windows and isn't included with the program. We should probably use our our own icon for the dark theme.

@ghost
Copy link

ghost commented Mar 22, 2019

@ferenczy You have to enable 'Use old colors' in the Graphs section, this makes the entire application have a dark theme. I guess it's like a hidden option for testing purposes?

And I know the above comment stated this but they didn't tag the person who asked the question so they might not have seen it.

@KaKi87
Copy link

KaKi87 commented Sep 15, 2019

Hey there, what's the status here ? :)

@KaKi87
Copy link

KaKi87 commented Jan 21, 2020

up

@dmex
Copy link
Collaborator

dmex commented Jan 21, 2020

@KaKi87

The nightly builds support dark themes when you select the "Enable theme support" checkbox on the options window 👍
https://wj32.org/processhacker/nightly.php

@KaKi87
Copy link

KaKi87 commented Jan 22, 2020

Thanks !
When will 3.0 be stable ?

@dmex
Copy link
Collaborator

dmex commented Jan 23, 2020

@KaKi87

3.0 is stable if you consider the standard set by Windows 10 😄

@KaKi87
Copy link

KaKi87 commented Jan 24, 2020

Nice ! Well, I'm using skip ahead builds on my daily use computer and I find it more stable than the stable release channel lol 😂 So, it seems nice, thanks !
But it was still a serious question xD

@dmex
Copy link
Collaborator

dmex commented Jan 25, 2020

But it was still a serious question xD

It was a serious answer. The development standard for Windows 10 is the same standard for the nightly builds of Process Hacker.

Microsoft developers push all Windows changes to a git repository which are compiled nightly on Azure and these builds are pushed to the "preview ring" before they're later "released" to the public (Microsoft has discussed this process a few times).

We push changes to our github repository which are compiled (semi) nightly on Appveyor (hosted by Azure) and these builds are pushed to the "nightly" branch and made available to everyone using 3.0 builds.

The biggest difference between the two is that when issues are reported to our project issue tracker we can make the changes available to everyone in less than five minutes (the time appveyor takes to compile the nightly builds) meaning if there is an security issue or a faulty commit it can and does generally get reverted and/or fixed in less than five minutes.

This process is more visible on Github since everything is public (Windows Calculator and .NET Core are also hosted on Github) and we're following the same standard. The ability to make changes available in minutes compared to months makes things easier and generally more accepted by users these days than previously since things can be changed and fixed quickly.

There will be a new "stable" release soon for the LTS - Long Term Support - version which is just a version of the nightly build that doesn't have any reported issues.

@KaKi87
Copy link

KaKi87 commented Jan 25, 2020

I understand, but even when all issues are fixed, what makes a release stable is the fact that it has been fully tested before release, while a nightly isn't.

dmex added a commit that referenced this issue Feb 16, 2020
dmex added a commit that referenced this issue Apr 27, 2021
@onliner2021
Copy link

Is there any way to change the bright background colors?
In settings there are all sorts of colors one can change, but not the bright ones.
My Windows is running in "dark" mode, but I have not changed it to high contrast mode, as that puts rectangles everywhere...
And I also would like to avoid changing the Windows default colors with something like...
https://www.wintools.info/index.php/classic-color-panel
...as there are more than enough programs out there, that have very poor support for changed windows default colors...

It would be great if Process Hacker could provide support for changing the background and font colors so that one can have a true dark mode - totally independent of what the windows settings might be.

Thanks for considering.

@adamency
Copy link

Is this feature still not stable enough to be included in the stable release ?

@dmex dmex closed this as completed Jul 27, 2022
@moonspeak
Copy link

Is there any support for automatic theme switching? I use AutoDarkMode to switch Windows between light and dark based on the time of day, which is amazing for visibility. It seems this theme implementation simply changes the app colors until the feature is disabled. Is there any way to make it follow the system theme or any plans to do so? That would be amazing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants