JSON String interpolation not working as expected.

[Nepoxx]

The following code:

let logger = require('winston')

logger.log('info', 'test %j', {a: 5, b: 10})
logger.info('test %j', {a: 5, b: 10})

Results in:

info: test %j a=5, b=10
info: test %j a=5, b=10

This is not as expected and described here.

[indexzero]

Potentially fixed by #737. Could you try to reproduce with that fork and let me know?

[Nepoxx]

Tested pr/737, works as expected:

info: test {"a":5,"b":10}
info: test {"a":5,"b":10}

[indexzero]

@Nepoxx will try to get this fixed on Friday during our winston maintenance. But #737 breaks a number of tests, so will need to find another approach.

[jsumners]

Sooooo, how's this coming along?

[indexzero]

@jsumners due to a variety of factors dev work has been slowed the last couple of weeks. Hoping to change that in a few weeks.

[alexandrubau]

Hi guys, any news regarding this fix?
I think it's the same with #774.

Thanks

[sandrocsimas]

+1

[alexandrubau]

The PR #777 seems to be a fix.

[indexzero]

@alexandrubau I think this is unrelated to #777. The bug itself appears to be in the lack of check of length in the interpolation matches vs. the number of arguments defined. See the code: https://github.com/winstonjs/winston/blob/master/lib/winston/logger.js#L170

[jsumners]

I submitted a potential fix for this a few days ago. Has anyone had a chance to review it?

[thomasdelaet]

+1

[thomasdelaet]

Hey,

I think I fixed this while developing this wrapper

[indexzero]

Fixed by #835