Fix handling of meta objects in log messages #737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix handling of meta objects in log messages. As of 2.0.0 objects that are passed to log statements and not bound by any format char were being identified as part of the msg instead of meta.
|
This has broken a lot of tests. Could you provide a small example of the problem you're seeing? |
|
@aldelucca1 ping. Could you provide a code sample that is producing the behavior so that we can investigate more deeply? |
|
When is it going to be merged ? I'm having the same issue. |
|
@alexandrubau the PR needs to be rebased and an approach needs to be found that does not break so many tests because its not handling all cases if tests are breaking |
|
Closing this PR since there has been no activity from @aldelucca1 in about a month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix handling of meta objects in log messages. As of 2.0.0 objects that are passed to log statements and not bound by any format char were being identified as part of the msg instead of meta.