Fix bugs in createLogger type
#1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DABH
approved these changes
Jun 22, 2020
rossanmol
reviewed
Jun 23, 2020
| notice: number; | ||
| } | ||
|
|
||
| type Logger<T extends Config.AbstractConfigSetLevels = DefaulLevels> = NodeJSStream.Transform & { |
There was a problem hiding this comment.
To prevent any breaking changes, generic should be T extends Config.AbstractConfigSetLevels = DefaultLevels | Config.AbstractConfigSetLevels
Mizumaki
added a commit
to Mizumaki/winston
that referenced
this pull request
Jun 23, 2020
Merged
DABH
pushed a commit
that referenced
this pull request
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lack of type correctness, and it causes TypeScript error when we set
levelsoption.This PR aims to fix it.
Problem
We can set
levelsoption increateLogger. For this option, you can use any string as a log level.However, in the type world, it wasn't accepted.
Additionally, there is more bug in here.
Following the implementation, if we set the
levelsoption, the default levels options are overridden. However, in type world, it was accepted.After this PR
Works with
levelsoption.Of course, without
levelsoption, defaultlevelsare inferred correctly.