Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize DynamicProxy #357

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Optimize DynamicProxy #357

merged 1 commit into from
Mar 27, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Jan 15, 2020

Based on #356

This PR made large changes to two "public" classes. I'm assuming this is used as a console program so API changes are OK?

@nxtn nxtn changed the title Simplify DynamicProxy Optimize DynamicProxy Jan 19, 2020
@oleg-nenashev oleg-nenashev changed the base branch from master to test-4.x January 20, 2020 04:56
@oleg-nenashev oleg-nenashev changed the base branch from test-4.x to master January 20, 2020 04:57
@oleg-nenashev
Copy link
Member

This PR made large changes to two "public" classes. I'm assuming this is used as a console program so API changes are OK?

Yes, there is no binary compatibility commitment. We can also consider cutting a new major release taking all other changes

@nxtn nxtn mentioned this pull request Jan 20, 2020
Merged
@oleg-nenashev oleg-nenashev added the internal Internal changes and maintenance label Mar 27, 2020
oleg-nenashev
oleg-nenashev approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was easier to review this change in IDE. I do not see anything wrong in this refactoring, thanks!

@nxtn nxtn added this to the 2.x milestone Mar 27, 2020
@nxtn nxtn merged commit 3f58cde into winsw:master Mar 27, 2020
@nxtn nxtn deleted the emit branch March 27, 2020 16:01
@nxtn nxtn modified the milestones: 2.Next, 2.7.0 Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
internal Internal changes and maintenance
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nxtn @oleg-nenashev