Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from *System.Management* to MMI #366

Merged
merged 2 commits into from Feb 6, 2020
Merged

Migrate from *System.Management* to MMI #366

merged 2 commits into from Feb 6, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Jan 20, 2020

Conflicts with #357

System.Management has been deprecated. There are such notes everywhere in the docs.

System.Management was the original .NET namespace used to access WMI; however, the APIs in this namespace generally are slower and do not scale as well relative to their more modern Microsoft.Management.Infrastructure counterparts.

@nxtn
Copy link
Contributor Author

nxtn commented Jan 21, 2020

MMI carries native libraries, so I'll probably change to only use it on .NET Core.

@nxtn nxtn marked this pull request as ready for review January 22, 2020 11:29
@oleg-nenashev oleg-nenashev added the internal Internal changes and maintenance label Feb 5, 2020
@oleg-nenashev oleg-nenashev changed the title Migrate to MMI Migrate from System.Management to MMI Feb 5, 2020
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend to change CIM to a more self-descriptive name, but the rest looks good to me

@nxtn
Copy link
Contributor Author

nxtn commented Feb 5, 2020

I would recommend to change CIM to a more self-descriptive name

Like FEATURE_CIM/HAVE_CIM/WITH_CIM?

@oleg-nenashev
Copy link
Member

Yes. Maybe CIM_ENABLED and a link to https://docs.microsoft.com/en-us/windows/win32/wmisdk/common-information-model in comments

@oleg-nenashev oleg-nenashev merged commit eb96c4a into winsw:master Feb 6, 2020
@nxtn nxtn deleted the mmi branch February 6, 2020 10:17
@nxtn nxtn changed the title Migrate from System.Management to MMI Migrate from *System.Management* to MMI Mar 16, 2020
@nxtn nxtn added this to the 2.6.0 milestone Mar 25, 2020
@nxtn nxtn mentioned this pull request Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants