Update to latest Jest reporter API #25
Conversation
|
Please can this be merged in? |
|
@winterbe Is this repo still maintained? |
|
Yep but I’m on holidays afk. Will look into this later.
Mathieu Decoene <notifications@github.com> schrieb am Mo. 5. Nov. 2018 um
10:23:
… @winterbe <https://github.com/winterbe> Is this repo still maintained?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAdmqd2YSbFW_CYvrp9VLO7faUkBJtJ8ks5usAOWgaJpZM4XIhfL>
.
|
|
Could you merge this please |
|
+1 to merging this |
|
+2 to merging this! |
|
@winterbe can you please merge this. Fix works fine. Workaround for a meanwhile:
|
|
@winterbe any news on this? |
| * This should eventually be turned into a proper class (whenever the testResultsProcessor option is phased out) | ||
| * https://facebook.github.io/jest/docs/en/configuration.html#reporters-array-modulename-modulename-options | ||
| */ | ||
| this.onRunComplete = (_contexts, testResult) => { |
There was a problem hiding this comment.
this.onTestResult would be even better. It fires when tests from a particular file are finished
There was a problem hiding this comment.
Code coverage data will be enriched only for final results, wont'it?
There was a problem hiding this comment.
Then maybe it should be two separate listeners: onTestResult for logTestSuite and onRunComplete for logCoverage
@winterbe Sorry for rushing this a bit, but holidays ended yet? |
|
This seems to be a good replacement that works with the latest Jest: https://github.com/itereshchenkov/jest-teamcity |
This update should still be backwards compatible, but it will also work with the latest versions of Jest.