Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a delay to give the widget enough time to show the just add… #919

Merged

Conversation

lex0r
Copy link
Contributor

@lex0r lex0r commented Jun 9, 2023

…ed item before maxItem limit check is run.

This should address #42

…ed item before maxItem limit check is run.
@lex0r lex0r marked this pull request as ready for review June 9, 2023 10:50
@mjauvin
Copy link
Member

mjauvin commented Jun 10, 2023

@lex0r even using a timeout of ZERO works... not sure what difference that makes

@mjauvin
Copy link
Member

mjauvin commented Jun 10, 2023

@mjauvin
Copy link
Member

mjauvin commented Jun 10, 2023

I think this is an acceptable workaround.

Ultimately, it would be nice to find a more "global" fix for this race condition, if that's even possible.

@bennothommo bennothommo added this to the v1.2.3 milestone Jun 11, 2023
@bennothommo bennothommo merged commit 71705de into wintercms:develop Jun 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants