Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeater maxItems doesn't take effect for the first item #42

Closed
LukeTowers opened this issue Mar 16, 2021 · 7 comments
Closed

Repeater maxItems doesn't take effect for the first item #42

LukeTowers opened this issue Mar 16, 2021 · 7 comments
Assignees
Milestone

Comments

@LukeTowers
Copy link
Member

When using repeater with maxItems=1, repeater does not work correctly. It adds one record and still shows the button to add one more. When you remove all records and start adding them again, the repeater works as expected.

Test with the Test Plugin using the Countries > Related repeater and setting maxItems: 1

plugins\winter\test\models\country\fields.yaml

Initial report by @GinoPane in octobercms/october#5533

@LukeTowers LukeTowers added this to the v1.1.3 milestone Mar 16, 2021
@bennothommo bennothommo self-assigned this Mar 16, 2021
@bennothommo
Copy link
Member

@LukeTowers is this is still occurring? I cannot replicate on a fresh copy of Winter.

@bennothommo bennothommo added the needs response Issues/PRs where a maintainer is awaiting a response from the submitter label Mar 24, 2021
@LukeTowers
Copy link
Member Author

No idea. Will close.

@lex0r
Copy link
Contributor

lex0r commented Apr 17, 2023

I'm afraid the issue is still there and happens exactly as it was described by @LukeTowers on the latest Winter release

@bennothommo bennothommo reopened this Apr 18, 2023
@bennothommo bennothommo added needs review Issues/PRs that require a review from a maintainer and removed needs response Issues/PRs where a maintainer is awaiting a response from the submitter labels Apr 18, 2023
@lex0r
Copy link
Contributor

lex0r commented Jun 9, 2023

A possible fix
#919

Copy link

github-actions bot commented Dec 9, 2023

This issue will be closed and archived in 3 days, as there has been no activity in this issue for the last 6 months.
If this issue is still relevant or you would like to see it actioned, please respond within 3 days.
If this issue is critical for your business, please reach out to us at wintercms@luketowers.ca.

@github-actions github-actions bot added the stale Issues/PRs that have had no activity and may be archived label Dec 9, 2023
@bennothommo bennothommo added Status: Completed and removed stale Issues/PRs that have had no activity and may be archived needs review Issues/PRs that require a review from a maintainer labels Dec 12, 2023
@LukeTowers
Copy link
Member Author

Fixed by #919

@lex0r
Copy link
Contributor

lex0r commented Sep 10, 2024

The issue is happening again because of wrong jQuery selector for the "Add" button. The fix was suggested here:
#1199

FYI @LukeTowers @bennothommo

LukeTowers pushed a commit that referenced this issue Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants