Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return non-zero value when unsuccessfully exiting #13

Merged
merged 1 commit into from
Aug 21, 2013

Conversation

alxndr
Copy link
Contributor

@alxndr alxndr commented Aug 16, 2013

bash treats a zero return value as a success. gitc still returns zero if it encounters an error during an operation.

11:01:57 (rc-12350-backbonize-mediajs)
~/workspace/br/breport $ gitc pull

Retrieving branch information from gitcycle.

Fetching remote 'br'.


Merging remote branch 'rc' from 'br/breport'.

error: Your local changes to the following files would be overwritten by merge:
    public/javascripts/backbone/views/media_video_view.js
Please, commit your changes or stash them before you can merge.
Aborting


Gitcycle encountered an error when running the last command:
  git merge br/rc
Please copy this session's output and send it to gitcycle@bleacherreport.com.


11:02:04 (rc-12350-backbonize-mediajs)
~/workspace/br/breport $ echo $?
0

This means that chaining commands like gitc pull && bundle doesn't end up doing what you'd expect.

winton added a commit that referenced this pull request Aug 21, 2013
return non-zero value when unsuccessfully exiting
@winton winton merged commit f3160f1 into winton:master Aug 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants