Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit status isn't updated when pushing to existing Pull Request #8

Closed
jarrodldavis opened this issue Oct 1, 2017 · 5 comments · Fixed by #14
Closed

Commit status isn't updated when pushing to existing Pull Request #8

jarrodldavis opened this issue Oct 1, 2017 · 5 comments · Fixed by #14

Comments

@jarrodldavis
Copy link

I've noticed that when an existing Pull Request is updated with new commits, this app doesn't set a commit status until the title is changed (or at least re-saved with the same text). For example, my initial commit here has a correctly-set status but the current head doesn't have any status from wip-bot.

@gr2m
Copy link
Collaborator

gr2m commented Oct 1, 2017

Thanks for reporting the issue! By the way the logs are public in case you run into any trouble: wip-bot.now.sh/_logs logs are no longer public as of 5/25/18

In your case it at least claims that it set status to error: https://zeit.co/gr2m/wip-bot/ggkwiearje/logs?redirect=1&query=https%3A%2F%2Fgithub.com%2Fjarrodldavis%2Fprobot-gpg%2Fpull%2F43

I’ll investigate

@gr2m
Copy link
Collaborator

gr2m commented Oct 1, 2017

Ah I get what you mean now, it set the status, but it did not set it again after you pushed a commit

@cmalard
Copy link

cmalard commented Oct 5, 2017

Just ran into this, hope you can do it 🍻

@gr2m
Copy link
Collaborator

gr2m commented Oct 16, 2017

whee I just found out an easy fix for this, thanks to a tip @bkeepers, PR incoming 🎉

gr2m added a commit that referenced this issue Oct 16, 2017
@gr2m gr2m closed this as completed in #14 Oct 16, 2017
gr2m added a commit that referenced this issue Oct 16, 2017
@gr2m
Copy link
Collaborator

gr2m commented Oct 17, 2017

this should no be resolved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants