feat: add logger with userId and clientId #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* feat: add logger with userid and clientid * update lib version * added some documentation to the KaliumLogger tags * moved creating string tag to Tag sealed class * fix detekt * fix tests
github-actions
bot
added
the
cherry-pick
7 tasks
…serid-and-clientid-cherry-pick
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
saleniuk
requested review from
a team,
typfel,
gongracr,
yamilmedina,
borichellow and
Garzas
and removed request for
a team
Garzas
approved these changes
Oct 17, 2023
gradle/libs.versions.toml
Outdated
| @@ -39,8 +39,8 @@ jna = "5.13.0" | |||
| core-crypto = "1.0.0-rc.12" | |||
| core-crypto-multiplatform = "0.6.0-rc.3-multiplatform-pre1" | |||
| completeKotlin = "1.1.0" | |||
| desugar-jdk = "2.0.3" | |||
| kermit = "1.2.2" | |||
| desugar-jdk = "1.1.5" | |||
There was a problem hiding this comment.
IIRC, we can't downgrade to 1.x on develop without risking some crashes during runtime.
There was a problem hiding this comment.
Automatic cherry-pick did that, it was supposed to just update kermit, I didn't notice that it also changed the one above, sorry about that. Reverted.
vitorhugods
requested changes
Oct 17, 2023
gradle/libs.versions.toml
Outdated
| @@ -39,8 +39,8 @@ jna = "5.13.0" | |||
| core-crypto = "1.0.0-rc.12" | |||
| core-crypto-multiplatform = "0.6.0-rc.3-multiplatform-pre1" | |||
| completeKotlin = "1.1.0" | |||
| desugar-jdk = "2.0.3" | |||
| kermit = "1.2.2" | |||
| desugar-jdk = "1.1.5" | |||
There was a problem hiding this comment.
IIRC, we can't downgrade to 1.x on develop without risking some crashes during runtime.
…serid-and-clientid-cherry-pick
Codecov Report
@@ Coverage Diff @@
## develop #2139 +/- ##
=============================================
- Coverage 57.74% 57.73% -0.01%
+ Complexity 24 21 -3
=============================================
Files 1052 1052
Lines 40027 40057 +30
Branches 3716 3719 +3
=============================================
+ Hits 23113 23128 +15
- Misses 15305 15322 +17
+ Partials 1609 1607 -2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
vitorhugods
approved these changes
Oct 17, 2023
vitorhugods
deleted the
feat/logger-with-userid-and-clientid-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Currently logs are not associated with specific user and client which makes debugging harder.
Solutions
Create a logger in user scope that can pass userId and clientId with each log.
Testing
Test Coverage (Optional)
How to Test
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.