-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: detect team app lock change (WPB-4476) #2183
Conversation
…to observe_team_app_lock_config
…ck_change # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/event/Event.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/applock/AppLockTeamFeatureConfigObserver.kt # logic/src/commonTest/kotlin/com/wire/kalium/logic/feature/applock/AppLockTeamFeatureConfigObserverTest.kt
Datadog ReportBranch report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small code style suggestion :)
.../commonMain/kotlin/com/wire/kalium/logic/feature/applock/AppLockTeamFeatureConfigObserver.kt
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #2183 +/- ##
=============================================
- Coverage 57.94% 57.93% -0.02%
Complexity 21 21
=============================================
Files 1067 1069 +2
Lines 40544 40588 +44
Branches 3749 3757 +8
=============================================
+ Hits 23495 23515 +20
- Misses 15433 15453 +20
- Partials 1616 1620 +4
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Description
In this PR I:
isChanged
value that will be used by client to display a dialog in case the config has changed.Dependencies (Optional)
Needed for wireapp/wire-android#2388
How to Test
Not testable only logic here
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.