Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove crlcheckWorker and featureWorker from running in userSession (WPB-7213) #2672

Merged

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Mar 20, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Needed for this PR
wireapp/wire-android#2803

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Mar 20, 2024

Test Results

2 846 tests   2 717 ✔️  32s ⏱️
   487 suites     129 💤
   487 files           0

Results for commit b1fa17b.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/candidate@cccff38). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #2672   +/-   ##
====================================================
  Coverage                     ?   58.33%           
  Complexity                   ?        7           
====================================================
  Files                        ?     1176           
  Lines                        ?    46172           
  Branches                     ?     4380           
====================================================
  Hits                         ?    26935           
  Misses                       ?    17276           
  Partials                     ?     1961           
Files Coverage Δ
...ature/e2ei/CertificateRevocationListCheckWorker.kt 84.21% <ø> (ø)
...ic/feature/featureConfig/FeatureFlagsSyncWorker.kt 96.55% <ø> (ø)
...in/com/wire/kalium/logic/feature/user/UserScope.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cccff38...8365424. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Mar 20, 2024

Datadog Report

Branch report: workers_not_running_when_persistent_ws_is_enabled
Commit report: 2d3de5b
Test service: kalium-jvm

✅ 0 Failed, 2847 Passed, 123 Skipped, 8m 37.04s Wall Time

…tent_ws_is_enabled

# Conflicts:
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt
@ohassine ohassine enabled auto-merge (squash) March 25, 2024 10:28
@ohassine ohassine disabled auto-merge March 25, 2024 10:32
@ohassine ohassine merged commit b65962a into release/candidate Mar 25, 2024
17 checks passed
@ohassine ohassine deleted the workers_not_running_when_persistent_ws_is_enabled branch March 25, 2024 11:00
github-actions bot pushed a commit that referenced this pull request Mar 25, 2024
…ion (WPB-7213) (#2672)

* fix: run crlCheckWorker and FeatureFlagsSyncWorker on every app launch

* chore: detekt

* chore: detekt
github-merge-queue bot pushed a commit that referenced this pull request Mar 25, 2024
…ion (WPB-7213) (#2672) (#2682)

* fix: run crlCheckWorker and FeatureFlagsSyncWorker on every app launch

* chore: detekt

* chore: detekt

Co-authored-by: Oussama Hassine <oussama.has100@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants