Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

chore: Use Node.js 12 #12

Merged
merged 10 commits into from
May 7, 2019
Merged

chore: Use Node.js 12 #12

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d0a2b32
chore: Use Node.js 12
ffflorian May 7, 2019
6d44568
add if case
ffflorian May 7, 2019
b2cbbc9
add space
ffflorian May 7, 2019
730cd98
better if check
ffflorian May 7, 2019
3be3373
formatting
ffflorian May 7, 2019
b5cdc9e
[ci skip] formatting
ffflorian May 7, 2019
077be6a
[ci skip] formatting
ffflorian May 7, 2019
5faebe8
build and run when testing
ffflorian May 7, 2019
10dc715
don't rebuild twice
ffflorian May 7, 2019
644d81e
don't run example
ffflorian May 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ os: osx
language: node_js

node_js:
- '10'
- '12'

notifications:
email: false
Expand Down
15 changes: 1 addition & 14 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,5 @@
{
"author": "Wire Swiss <wireapp@wire.com>",
"contributors": [
{
"email": "chris@wire.com",
"name": "Chris Owen",
"url": "http://wire.com"
},
{
"email": "digital.flowers@hotmail.com",
"name": "Fareed Al-Namrouti"
}
],
Copy link
Contributor Author

@ffflorian ffflorian May 7, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list was incomplete and can now be found at https://github.com/wireapp/node-addressbook/graphs/contributors

"dependencies": {
"nan": "2.13.2"
},
Expand Down Expand Up @@ -48,9 +37,7 @@
"address",
"addressbook",
"contacts",
"wire",
"binding",
"c"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless IMO

"binding"
],
"license": "GPL-3.0",
"lint-staged": {
Expand Down
4 changes: 2 additions & 2 deletions src/cpp/wrapper.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ NAN_METHOD(GetMe) {


NAN_METHOD(GetContact) {
int index = info[0]->Uint32Value();
int index = info[0]->Uint32Value(Nan::GetCurrentContext()).ToChecked();

AddressBook ab;
Isolate* isolate = Isolate::GetCurrent();
Expand Down Expand Up @@ -144,4 +144,4 @@ NAN_MODULE_INIT(Init) {
GetFunction(New<FunctionTemplate>(GetContacts)).ToLocalChecked());
}

NODE_MODULE(addon, Init)
NODE_MODULE(addon, Init)