check for empty payload.url (#130)

* check for empty payload.url * more logging
wireapp · Dec 6, 2023 · bf78793 · bf78793
1 parent 3d2222a
commit bf78793
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/backend/src/main/java/com/wire/bots/roman/resources/ServiceResource.java b/backend/src/main/java/com/wire/bots/roman/resources/ServiceResource.java
@@ -25,6 +25,7 @@
 
 import jakarta.validation.Valid;
 import jakarta.validation.constraints.NotNull;
+
 import java.net.MalformedURLException;
 import java.net.URISyntaxException;
 import java.net.URL;
@@ -61,6 +62,11 @@ public Response create(@ApiParam(hidden = true) @CookieParam(Z_ROMAN) String tok
                            @Context ContainerRequestContext context,
                            @ApiParam @Valid _NewService payload) {
         try {
+            //hack
+            if (payload.url != null && payload.url.isEmpty()) {
+                payload.url = null;
+            }
+
             UUID providerId = (UUID) context.getProperty(Const.PROVIDER_ID);
 
             Provider provider = providersDAO.get(providerId);
@@ -122,7 +128,7 @@ public Response create(@ApiParam(hidden = true) @CookieParam(Z_ROMAN) String tok
 
                 if (update.getStatus() >= 400) {
                     String msg = update.readEntity(String.class);
-                    Logger.debug("ServiceResource.create: enable service response: %s", msg);
+                    Logger.debug("ServiceResource.create: enable service (%s) response: %s", service.id, msg);
                     return Response.
                             ok(msg).
                             status(update.getStatus()).
@@ -355,7 +361,7 @@ static class _NewService {
         @ValidationMethod(message = "`url` is not a valid URL")
         @JsonIgnore
         public boolean isUrlValid() {
-            if (url == null)
+            if (url == null || url.isEmpty())
                 return true;
             try {
                 new URL(url).toURI();