Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lithium deps - compiling, breaking test #118

Closed

Conversation

yamilmedina
Copy link
Collaborator

@yamilmedina yamilmedina commented Nov 28, 2023

What's new in this PR?

WIP: Trying to make Roman to compile due to lithium's migration to jakarta

Note: Did not test. I have the feeling that the Filters / SPI / Loggers need some work, or roman.yaml file configure accordingly, since SPI definitions were removed from lithium

Testing

Test Coverage (Optional)

Warning

Tests are breaking, do not merge.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant