Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: testing setup for roman (WPB-5794) #140

Merged
merged 19 commits into from
Dec 18, 2023
Merged

Conversation

yamilmedina
Copy link
Collaborator

@yamilmedina yamilmedina commented Dec 18, 2023


PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Adds tests to roman and run it on ci.

Solutions

Since we have dependencies with cryptobox, we are running tests in a containerized environment, using docker-compose And extracting/export the results so we can use it later for publishing.

  • adds maven wrapper
  • adds docker files execution and scripts to setup test environment

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

github-actions bot commented Dec 18, 2023

Test Results

8 tests   7 ✔️  7s ⏱️
4 suites  1 💤
4 files    0

Results for commit eb73824.

♻️ This comment has been updated with latest results.

@yamilmedina yamilmedina marked this pull request as ready for review December 18, 2023 13:52
@yamilmedina yamilmedina self-assigned this Dec 18, 2023
@yamilmedina yamilmedina changed the title feat: testing setup for roman feat: testing setup for roman (WPB-5794) Dec 18, 2023
@dkovacevic dkovacevic merged commit 756fc3b into staging Dec 18, 2023
3 checks passed
@yamilmedina yamilmedina deleted the feat/test-setup branch December 18, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants