-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: ignore mention with negative index [WPB-4854] (#2270)
- Loading branch information
Showing
2 changed files
with
109 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 changes: 96 additions & 0 deletions
96
app/src/test/kotlin/com/wire/android/ui/home/conversations/model/MessageTypesTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| /* | ||
| * Wire | ||
| * Copyright (C) 2023 Wire Swiss GmbH | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see http://www.gnu.org/licenses/. | ||
| */ | ||
| package com.wire.android.ui.home.conversations.model | ||
|
|
||
| import android.content.res.Resources | ||
| import com.wire.android.framework.TestUser | ||
| import com.wire.android.ui.markdown.MarkdownConstants | ||
| import com.wire.android.util.ui.UIText | ||
| import com.wire.kalium.logic.data.message.mention.MessageMention | ||
| import io.mockk.MockKAnnotations | ||
| import io.mockk.every | ||
| import io.mockk.impl.annotations.MockK | ||
| import org.amshove.kluent.internal.assertEquals | ||
| import org.junit.jupiter.api.Assertions.assertTrue | ||
| import org.junit.jupiter.api.Test | ||
|
|
||
| class MessageTypesTest { | ||
|
|
||
| @MockK | ||
| lateinit var mockResources: Resources | ||
|
|
||
| init { | ||
| MockKAnnotations.init(this, relaxUnitFun = true) | ||
|
|
||
| every { mockResources.getString(any()) } returns "mockedString" | ||
| } | ||
|
|
||
| @Test | ||
| fun `Given message with no mentions when mapping then no mentions should be returned`() { | ||
| val uiText = UIText.DynamicString("Hello world") | ||
| val result = mapToDisplayMentions(uiText, mockResources) | ||
| assertTrue(result.first.isEmpty()) | ||
| assertEquals("Hello world", result.second) | ||
| } | ||
|
|
||
| @Test | ||
| fun `Given message with a valid mention when mapping then the mention should be returned with markers`() { | ||
| val mention = MessageMention(0, 6, TestUser.USER_ID, isSelfMention = false) | ||
| val uiText = UIText.DynamicString("@Hello world", listOf(mention)) | ||
| val result = mapToDisplayMentions(uiText, mockResources) | ||
| assertEquals(1, result.first.size) | ||
| assertEquals("@Hello", result.first.first().mentionUserName) | ||
| assertEquals("${MarkdownConstants.MENTION_MARK}@Hello${MarkdownConstants.MENTION_MARK} world", result.second) | ||
| } | ||
|
|
||
| @Test | ||
| fun `Given message with a negative start mention when mapping then no mentions should be returned`() { | ||
| val mention = MessageMention(-1, 5, TestUser.USER_ID, isSelfMention = false) | ||
| val uiText = UIText.DynamicString("Hello world", listOf(mention)) | ||
| val result = mapToDisplayMentions(uiText, mockResources) | ||
| assertTrue(result.first.isEmpty()) | ||
| assertEquals("Hello world", result.second) | ||
| } | ||
|
|
||
| @Test | ||
| fun `Given message with a mention exceeding string length when mapping then no mentions should be returned`() { | ||
| val mention = MessageMention(10, 20, TestUser.USER_ID, isSelfMention = false) | ||
| val uiText = UIText.DynamicString("Hello world", listOf(mention)) | ||
| val result = mapToDisplayMentions(uiText, mockResources) | ||
| assertTrue(result.first.isEmpty()) | ||
| assertEquals("Hello world", result.second) | ||
| } | ||
|
|
||
| @Test | ||
| fun `Given message where mention's start position doesn't have '@' character when mapping then no mentions should be returned`() { | ||
| val mention = MessageMention(6, 5, TestUser.USER_ID, isSelfMention = false) | ||
| val uiText = UIText.DynamicString("Hello world", listOf(mention)) | ||
| val result = mapToDisplayMentions(uiText, mockResources) | ||
| assertTrue(result.first.isEmpty()) | ||
| assertEquals("Hello world", result.second) | ||
| } | ||
|
|
||
| @Test | ||
| fun `Given message with multiple mentions when mapping then only valid mentions should be returned`() { | ||
| val validMention = MessageMention(6, 5, TestUser.USER_ID, isSelfMention = false) | ||
| val invalidMention = MessageMention(50, 5, TestUser.OTHER_USER.id, isSelfMention = false) | ||
| val uiText = UIText.DynamicString("Hello @world", listOf(validMention, invalidMention)) | ||
| val result = mapToDisplayMentions(uiText, mockResources) | ||
| assertEquals(1, result.first.size) | ||
| } | ||
| } |