Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: audio messages partial delivery missing (WPB-4886) #2279

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

yamilmedina
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Failures for audio messages are not displaying the partial delivery information.

Solutions

Add the component that displays this info message to audio messages.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Sep 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

Test Results

593 tests   592 ✔️  6m 33s ⏱️
  85 suites      1 💤
  85 files        0

Results for commit cd1de40.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1035 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina requested review from a team, gongracr, alexandreferris, MohamadJaara, vitorhugods and Garzas and removed request for a team September 27, 2023 17:16
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina merged commit 17844fe into release/candidate Sep 28, 2023
10 of 11 checks passed
@yamilmedina yamilmedina deleted the fix/audiomessages-partial-delivery branch September 28, 2023 09:44
@AndroidBob
Copy link
Collaborator

Build 1039 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants