Registration #5: Add e-mail entry layout

[gizemb]

• Sets up dependency injection infrastructure
• Adds TextInputLayout style
• Adds circular button

TODO: Still needs updating cursor color on editable fields

[gizemb]

@android10 is there a better place to put this? I couldn't put it under compilation.gradle.kts because it requires kotlin plugin.

[BradleyIW]

Could we not add the kotlin gradle plugin to the buildSrc/build.gradle.kts dependencies closure to allow for this to be used within the scripts? (also could you make the Dependencies object private in there too if we do decide to add this plugin)

[gizemb]

I need some guidance from Fernando on this. I couldn't even create a .gradle.kts file :D

[android10]

@Gizem I would not start mixing things up. AFAIK we do not need this right? By default it compiles against Java 8.
In case you need it, maybe I can raise a PR tomorrow and provide more context but I would extract all this and keep the build.gradle.kts as small and clean possible.

@BradleyWire I do not understand your point. "Dependencies" cannot be private. buildSrc is a separated project that builds stuff up, which becomes available to the rest of gradle scripts.

[BradleyIW]

@android10 Dependencies is the object inside your build.gradle.kts inside the buildSrc module, it doesn't need to have public access seeing as it's only constant belongs in the same file as it's own

object Dependencies {
    const val AndroidBuildTools = "com.android.tools.build:gradle:4.0.0"
}

I'd be safe in assuming this only need to be private to the file. It's a minor cosmetic change and is out of the scope of this PR which is why I asked to only change it if you're adding a dependency change to the gradle file.

[android10]

Ok. I thought you were talking about something else.
Here is the fix:
https://github.com/wireapp/wire-android-reloaded/pull/12/files

[BradleyIW]

Thanks @android10, Also, you'll need the kotlinOptions closure eventually otherwise you'll run into a complaint from the Kotlin compiler:

Cannot inline bytecode built with JVM target 1.8 into bytecode that is being built with JVM target 1.6

I've ran into this previously with the observe(..) extension function when observing a LiveData instance (which is heavily used in our architecture)

[android10]

Only a couple of points that need and answer. Then 👍 😄

[android10]

@Gizem I would not start mixing things up. AFAIK we do not need this right? By default it compiles against Java 8.
In case you need it, maybe I can raise a PR tomorrow and provide more context but I would extract all this and keep the build.gradle.kts as small and clean possible.

@BradleyWire I do not understand your point. "Dependencies" cannot be private. buildSrc is a separated project that builds stuff up, which becomes available to the rest of gradle scripts.

[android10]

As I pointed out in the other PR with the styles: Brackets {} are fine to keep them this way in order to favor the readability of the expression, but the arguments...mmm...I do not see it and I think we are not writing concise Kotlin code. This is how it would look for me:

        startKoin {
            androidContext(context)
            modules(listOf(coreModules, sharedModules, featureModules).flatten())
        }

I would also be of the idea of extracting the list of modules to a constant.

[gizemb]

combined them into a single line. I didn't feel the need to create a new variable for the module list. If we have one more in the future, I can add it.

[android10]

I only added a tiny thing apart from my last comments. Then 👍

[android10]

Ok. I thought you were talking about something else.
Here is the fix:
https://github.com/wireapp/wire-android-reloaded/pull/12/files

[android10]

That was such a great discussion. Great Job @gizemb 👍