Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Inform user about degraded conversation verification status (WPD-573) #1989

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Jul 21, 2023

What's new in this PR?

Added the new SystemMessage for the case when the conversation's verification status degraded.

Attachments (Optional)

PS: the typos are temporary as it's gonna be changed later.

Screenshot 2023-07-21 at 11 44 33 Screenshot 2023-07-21 at 11 44 18

Dependencies

Waitig for the Kalium PR:

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #1989 (63fcc8c) into develop (a5f5571) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #1989      +/-   ##
=============================================
- Coverage      38.54%   38.51%   -0.03%     
  Complexity       893      893              
=============================================
  Files            287      287              
  Lines          11328    11335       +7     
  Branches        1456     1459       +3     
=============================================
  Hits            4366     4366              
- Misses          6534     6541       +7     
  Partials         428      428              
Impacted Files Coverage Δ
.../wire/android/mapper/SystemMessageContentMapper.kt 35.96% <0.00%> (-0.98%) ⬇️
...e/android/ui/home/conversations/model/UIMessage.kt 45.87% <0.00%> (-0.67%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 398b709...63fcc8c. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023

Test Results

511 tests   510 ✔️  23s ⏱️
  74 suites      1 💤
  74 files        0

Results for commit 63fcc8c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 595 succeeded.

The build produced the following APK's:

@ohassine
Copy link
Member

In the screenshots we are showing the same message with two different icons, is that correct ?

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@borichellow
Copy link
Contributor Author

In the screenshots we are showing the same message with two different icons, is that correct ?

Currently, the Proteus message is not possible as the kalium part for that is not implemented yet, and these texts might be changed in the future to describe the exact reason for degrading verification (also not implemented yet).
So i'd say these texts are not important so far :)

@borichellow borichellow added this pull request to the merge queue Jul 24, 2023
@AndroidBob
Copy link
Collaborator

Build 623 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 925b4b2 Jul 24, 2023
13 of 14 checks passed
@borichellow borichellow deleted the feat/inform_user_about_degraded_conversation_verification_status branch July 24, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants