Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: internal app is not publishing to store #1993

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

publishing internal app to store is not working on jenkins

Solutions

the branch name should be internal and not Internal

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023

Test Results

511 tests   510 ✔️  34s ⏱️
  74 suites      1 💤
  74 files        0

Results for commit e7003ef.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 608 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara requested review from vitorhugods, a team, yamilmedina, alexandreferris, mchenani and trOnk12 and removed request for a team July 24, 2023 09:19
@vitorhugods vitorhugods changed the base branch from develop to release/candidate July 24, 2023 13:59
@AndroidBob
Copy link
Collaborator

Build 625 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara enabled auto-merge (squash) July 25, 2023 09:23
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 653 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara merged commit 334dd7f into release/candidate Jul 25, 2023
11 checks passed
@MohamadJaara MohamadJaara deleted the ci/internal_app_is_not_publishing branch July 25, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants