Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: E2EI required dialog cancelable #2013

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

borichellow
Copy link
Contributor

What's new in this PR?

Issues

E2EI required dialog is not cancelable

Causes (Optional)

thought it shouldn't be

Solutions

make it be cancelable

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #2013 (3a128ee) into develop (5e1959d) will increase coverage by 0.09%.
Report is 3 commits behind head on develop.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #2013      +/-   ##
=============================================
+ Coverage      38.54%   38.64%   +0.09%     
  Complexity       895      895              
=============================================
  Files            287      287              
  Lines          11347    11345       -2     
  Branches        1460     1460              
=============================================
+ Hits            4374     4384      +10     
+ Misses          6545     6536       -9     
+ Partials         428      425       -3     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e1959d...3a128ee. Read the comment docs.

@github-actions
Copy link
Contributor

Test Results

516 tests  ±0   515 ✔️ ±0   22s ⏱️ -5s
  74 suites ±0       1 💤 ±0 
  74 files   ±0       0 ±0 

Results for commit 3a128ee. ± Comparison against base commit 3c566bd.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 722 succeeded.

The build produced the following APK's:

@mchenani mchenani added this pull request to the merge queue Jul 26, 2023
Merged via the queue into develop with commit 346ab45 Jul 26, 2023
13 of 14 checks passed
@mchenani mchenani deleted the fix/e2ei_required_dialog_cancelable branch July 26, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants