Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Improve DD JUnit upload command (WPB-3489) #2017

Merged
merged 3 commits into from
Jul 28, 2023
Merged

chore: Improve DD JUnit upload command (WPB-3489) #2017

merged 3 commits into from
Jul 28, 2023

Conversation

SzymonMrozek
Copy link
Contributor

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

The previous command was not resolving all possible paths on ubuntu bash compared to local zsh shell

Solutions

Don't rely on bash resolving and manually pass paths

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@SzymonMrozek SzymonMrozek self-assigned this Jul 27, 2023
@AndroidBob
Copy link
Collaborator

Build 737 succeeded.

The build produced the following APK's:

@SzymonMrozek SzymonMrozek requested a review from tmspzz July 27, 2023 14:38
@AndroidBob
Copy link
Collaborator

Build 738 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023 •
edited

Test Results

518 tests  ±0   517 ✔️ ±0   20s ⏱️ -26s
  75 suites ±0       1 💤 ±0 
  75 files   ±0       0 ❌ ±0 

Results for commit 1263531. ± Comparison against base commit 2c70f21.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@SzymonMrozek SzymonMrozek force-pushed the chore/improve-dd-junit-upload branch from 2f002f7 to 1263531 Compare July 28, 2023 07:47
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 742 succeeded.

The build produced the following APK's:

@tmspzz tmspzz merged commit e93fda7 into develop Jul 28, 2023
13 checks passed
@tmspzz tmspzz deleted the chore/improve-dd-junit-upload branch July 28, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmspzz tmspzz tmspzz approved these changes

Assignees

@SzymonMrozek SzymonMrozek

Labels
size/XS
Projects
None yet
Milestone
No milestone
3 participants
@SzymonMrozek @AndroidBob @tmspzz