fix: Audio Message not being send with correct mimeType (WPB-3534) #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexandreferris
commented
Jul 31, 2023
Comment on lines
+120
to
+122
| val mimeType = if (audioPath != null) AUDIO_MIME_TYPE else attachmentUri | ||
| .getMimeType(context) | ||
| .orDefault(DEFAULT_FILE_MIME_TYPE) |
There was a problem hiding this comment.
This part specifically, if we go by getMimeType(..).. it would render as a VIDEO file due to its current mimeType being video/mp4 despite having only audio and no video data due to the way MediaRecorder creates the file.
alexandreferris
changed the title
|
Build 777 failed. |
alexandreferris
changed the title
|
Build 778 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 779 succeeded. The build produced the following APK's: |
alexandreferris
requested review from
a team,
gongracr,
yamilmedina,
Garzas,
trOnk12 and
ohassine
and removed request for
a team
Garzas
approved these changes
Aug 1, 2023
app/src/test/kotlin/com/wire/android/ui/home/conversations/MessageComposerViewModelTest.kt
Show resolved
Hide resolved
ohassine
reviewed
Aug 1, 2023
app/src/main/kotlin/com/wire/android/ui/home/conversations/MessageComposerViewModel.kt
Outdated
Show resolved
Hide resolved
|
Build 788 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 789 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
ohassine
approved these changes
Aug 1, 2023
|
Build 794 succeeded. The build produced the following APK's: |
|
Build 799 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Audio messages sent from Android would play on another Android device or Web, but not on iOS devices.
Causes (Optional)
We have 3 ways to send audio messages:
When sending from the recording feature, due to using
MediaRecorderthe end file mimeType resolves intovideo/mp4and notaudio/mp4, this doesn't occur when sending an audio message from other flows.Solutions
Unify sending/handling asset (normal asset and audio asset) with its respective Bundle classes and if it is an Audio asset, then we force its mimeType to
audio/mp4with extension as.m4aso its playable in all platforms.Testing
Test Coverage (Optional)
How to Test