-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show MLS info on device (WPB-2308) #2037
Conversation
Build 806 failed. |
Build 821 failed. |
Codecov Report
@@ Coverage Diff @@
## develop #2037 +/- ##
=============================================
+ Coverage 39.00% 39.01% +0.01%
Complexity 909 909
=============================================
Files 301 301
Lines 11135 11137 +2
Branches 1492 1492
=============================================
+ Hits 4343 4345 +2
Misses 6368 6368
Partials 424 424
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 823 succeeded. The build produced the following APK's: |
Text( | ||
style = MaterialTheme.wireTypography.subline01, | ||
color = MaterialTheme.wireColorScheme.labelText, | ||
maxLines = 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it really be maxLines = 1
?
I see it ends up cutting the thumbprint. Shouldn't we make sure that the whole thing is visible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is DeviceItem
from the list of all my devices (the first pair of screenshots), if you want to see the whole key - go to device screen :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✌️
APKs built during tests are available here. Scroll down to Artifacts! |
Build 877 succeeded. The build produced the following APK's: |
What's new in this PR?
Display the MLS info in the device settings
(Screenshots are self-explanatory)
Needs releases with:
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)