Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show MLS info on device (WPB-2308) #2037

Merged
merged 8 commits into from
Aug 3, 2023

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Aug 1, 2023

What's new in this PR?

Display the MLS info in the device settings
(Screenshots are self-explanatory)

Needs releases with:

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
Screenshot 2023-08-02 at 11 59 00 Screenshot 2023-08-02 at 11 54 11
Screenshot 2023-08-02 at 11 58 47 Screenshot 2023-08-02 at 11 53 59

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Test Results

506 tests  ±0   505 ✔️ ±0   5m 56s ⏱️ -40s
  76 suites ±0       1 💤 ±0 
  76 files   ±0       0 ±0 

Results for commit c3a7979. ± Comparison against base commit 5d8ad2e.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 806 failed.

@AndroidBob
Copy link
Collaborator

Build 821 failed.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #2037 (c3a7979) into develop (5d8ad2e) will increase coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #2037      +/-   ##
=============================================
+ Coverage      39.00%   39.01%   +0.01%     
  Complexity       909      909              
=============================================
  Files            301      301              
  Lines          11135    11137       +2     
  Branches        1492     1492              
=============================================
+ Hits            4343     4345       +2     
  Misses          6368     6368              
  Partials         424      424              
Files Changed Coverage Δ
.../android/ui/authentication/devices/model/Device.kt 94.44% <100.00%> (+0.69%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8ad2e...c3a7979. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 823 succeeded.

The build produced the following APK's:

Text(
style = MaterialTheme.wireTypography.subline01,
color = MaterialTheme.wireColorScheme.labelText,
maxLines = 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it really be maxLines = 1?

I see it ends up cutting the thumbprint. Shouldn't we make sure that the whole thing is visible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is DeviceItem from the list of all my devices (the first pair of screenshots), if you want to see the whole key - go to device screen :)

Copy link
Member

@mchenani mchenani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✌️

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@borichellow borichellow added this pull request to the merge queue Aug 3, 2023
@AndroidBob
Copy link
Collaborator

Build 877 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 21e1629 Aug 3, 2023
13 of 14 checks passed
@borichellow borichellow deleted the feat/show_mls_info_on_device branch August 3, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants