Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mention crashing on select after sending message #2053

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

trOnk12
Copy link
Contributor

@trOnk12 trOnk12 commented Aug 3, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • After users types @ and sends a message without selection item from the mention list, the app crashes next time user presses the item after the message is sent.

Solutions

  • Clear the mention search result after sending a text message.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@CLAassistant
Copy link

CLAassistant commented Aug 3, 2023

CLA assistant check
All committers have signed the CLA.

@trOnk12 trOnk12 changed the base branch from develop to release/candidate August 3, 2023 10:14
@trOnk12 trOnk12 changed the title Fix/mention crash fix: mention crash Aug 3, 2023
@trOnk12 trOnk12 changed the title fix: mention crash fix: mention crashing on select after sending message Aug 3, 2023
@ohassine
Copy link
Member

ohassine commented Aug 3, 2023

You are going to update kalium with a reference that does not exist, I can't see 7722de in RC branch of kalium.
Could you please recheck, correct reference is 8561d8c

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Test Results

512 tests   511 ✔️  31s ⏱️
  74 suites      1 💤
  74 files        0

Results for commit eb038ba.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@trOnk12 trOnk12 enabled auto-merge (squash) August 3, 2023 11:21
@AndroidBob
Copy link
Collaborator

Build 879 succeeded.

The build produced the following APK's:

@trOnk12 trOnk12 merged commit 678a6c4 into release/candidate Aug 3, 2023
12 of 13 checks passed
@trOnk12 trOnk12 deleted the fix/mention_crash branch August 3, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants