Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: E2EI certificat renew logic (WPB-3326) #2067

Merged
merged 18 commits into from
Aug 14, 2023

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Aug 7, 2023

What's new in this PR?

  • Added dialogs for: Remew E2EI certificate (with or without snooze), Error while creating/renewing E2EI certificate, Success after creating/renewing E2EI certificate.
  • Extracted all the E2EICertificate-related dialogs into a separate file
  • Updated FeatureFlagNotificationViewModel to handle a new implementation of ObserveE2EIRequiredUseCase

Release with

kalium PR

Attachments (Optional)

Screenshot 2023-08-11 at 12 39 17 Screenshot 2023-08-11 at 12 39 37

@borichellow borichellow added WIP Work In Progress DO NOT MERGE labels Aug 7, 2023
@CLAassistant
Copy link

CLAassistant commented Aug 7, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Test Results

536 tests  +3   535 ✔️ +3   5m 30s ⏱️ +4s
  79 suites ±0       1 💤 ±0 
  79 files   ±0       0 ±0 

Results for commit ff59a12. ± Comparison against base commit 5b28d21.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 936 failed.

@AndroidBob
Copy link
Collaborator

Build 937 failed.

@AndroidBob
Copy link
Collaborator

Build 1011 failed.

@AndroidBob
Copy link
Collaborator

Build 1014 failed.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #2067 (ff59a12) into develop (5b28d21) will increase coverage by 0.01%.
The diff coverage is 63.15%.

@@              Coverage Diff              @@
##             develop    #2067      +/-   ##
=============================================
+ Coverage      39.58%   39.60%   +0.01%     
  Complexity       930      930              
=============================================
  Files            305      305              
  Lines          11254    11262       +8     
  Branches        1499     1506       +7     
=============================================
+ Hits            4455     4460       +5     
  Misses          6370     6370              
- Partials         429      432       +3     
Files Changed Coverage Δ
...tlin/com/wire/android/ui/debug/DebugDataOptions.kt 0.00% <ø> (ø)
...in/kotlin/com/wire/android/mapper/MessageMapper.kt 62.00% <28.57%> (-0.63%) ⬇️
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 68.22% <66.66%> (-1.01%) ⬇️
...otlin/com/wire/android/ui/home/FeatureFlagState.kt 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b28d21...ff59a12. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1023 succeeded.

The build produced the following APK's:

@AndroidBob
Copy link
Collaborator

Build 1055 failed.

@AndroidBob
Copy link
Collaborator

Build 1058 failed.

@ohassine ohassine mentioned this pull request Aug 14, 2023
8 tasks
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@borichellow borichellow added this pull request to the merge queue Aug 14, 2023
@AndroidBob
Copy link
Collaborator

Build 1067 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 92b79c8 Aug 14, 2023
12 of 14 checks passed
@borichellow borichellow deleted the feat/e2ei_certificat_renew_logic branch August 14, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants