Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle non federated domain connection request (WPB-2219) #2068

Merged
merged 11 commits into from
Aug 8, 2023

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Aug 7, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There might be some cases, when we try to connect with users from target backends that we don't federate (ie, using members list of an old conversation)
So we need to handle this BE error response and present a message to the user.

Solutions

Parse in v4 endpoint the new error payload and bubble app federation type error.

Depends on

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Attachment

Screen.Recording.2023-08-07.at.16.34.01.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Test Results

509 tests  +1   508 ✔️ +1   6m 36s ⏱️ -47s
  77 suites ±0       1 💤 ±0 
  77 files   ±0       0 ±0 

Results for commit 200ed2a. ± Comparison against base commit b875f2b.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 938 failed.

@yamilmedina yamilmedina requested review from a team, gongracr, alexandreferris, borichellow, MohamadJaara, trOnk12 and Garzas and removed request for a team and gongracr August 7, 2023 15:15
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #2068 (3481611) into develop (b875f2b) will increase coverage by 0.02%.
The diff coverage is 78.57%.

❗ Current head 3481611 differs from pull request most recent head 200ed2a. Consider uploading reports for the commit 200ed2a to get more accurate results

@@              Coverage Diff              @@
##             develop    #2068      +/-   ##
=============================================
+ Coverage      39.08%   39.11%   +0.02%     
  Complexity       920      920              
=============================================
  Files            305      305              
  Lines          11166    11171       +5     
  Branches        1489     1490       +1     
=============================================
+ Hits            4364     4369       +5     
  Misses          6381     6381              
  Partials         421      421              
Files Changed Coverage Δ
...tions/details/AddMembersToConversationViewModel.kt 0.00% <ø> (ø)
...home/conversations/search/SearchPeopleViewModel.kt 68.69% <50.00%> (ø)
...d/ui/connection/ConnectionActionButtonViewModel.kt 73.73% <90.00%> (+1.39%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b875f2b...200ed2a. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 941 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 942 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina added this pull request to the merge queue Aug 8, 2023
Merged via the queue into develop with commit 5e3a9e3 Aug 8, 2023
11 checks passed
@yamilmedina yamilmedina deleted the feat/handle-nonfederated-connection-req branch August 8, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants