-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle non federated domain connection request (WPB-2219) #2068
Conversation
Build 938 failed. |
Codecov Report
@@ Coverage Diff @@
## develop #2068 +/- ##
=============================================
+ Coverage 39.08% 39.11% +0.02%
Complexity 920 920
=============================================
Files 305 305
Lines 11166 11171 +5
Branches 1489 1490 +1
=============================================
+ Hits 4364 4369 +5
Misses 6381 6381
Partials 421 421
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 941 succeeded. The build produced the following APK's: |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 942 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
There might be some cases, when we try to connect with users from target backends that we don't federate (ie, using members list of an old conversation)
So we need to handle this BE error response and present a message to the user.
Solutions
Parse in v4 endpoint the new error payload and bubble app federation type error.
Depends on
Testing
Test Coverage (Optional)
Attachment
Screen.Recording.2023-08-07.at.16.34.01.mov
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.