Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add audio asset metadata (WPB-3334) #2075

Merged
merged 7 commits into from
Aug 9, 2023

Conversation

alexandreferris
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

ssues
When sending audio messages from Android it wouldn't render the audio length in Android and also other platforms

Causes (Optional)
We were not sending audio metadata.

Solutions
Add and map audio metadata correctly when sending the asset.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • Open App
  • Open Conversation
  • Send Audio message and check:
    • Audio contains length before sending
    • Audio contains length on messages list
    • Audio contains length (check from other platforms Web/iOS)

@alexandreferris alexandreferris self-assigned this Aug 9, 2023
@alexandreferris alexandreferris requested review from a team, yamilmedina, MohamadJaara, vitorhugods, Garzas and saleniuk and removed request for a team August 9, 2023 08:45
@alexandreferris alexandreferris enabled auto-merge (squash) August 9, 2023 08:51
@AndroidBob
Copy link
Collaborator

Build 969 failed.

@AndroidBob
Copy link
Collaborator

Build 970 succeeded.

The build produced the following APK's:

@alexandreferris alexandreferris merged commit 74402c3 into release/candidate Aug 9, 2023
13 checks passed
@alexandreferris alexandreferris deleted the fix/add_audio_asset_metadata branch August 9, 2023 09:49
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants