Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more message status icons #2079

Merged
merged 25 commits into from
Aug 14, 2023
Merged

Conversation

trOnk12
Copy link
Contributor

@trOnk12 trOnk12 commented Aug 9, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Add support for read message status and delivered.

Needs releases with:

(wireapp/kalium#1943)

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

image

image


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@trOnk12 trOnk12 changed the title Feat/message status lifecycle feat: add more message status icons Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Test Results

537 tests  +1   536 ✔️ +1   4m 52s ⏱️ -14s
  79 suites ±0       1 💤 ±0 
  79 files   ±0       0 ±0 

Results for commit 05cdfda. ± Comparison against base commit 92b79c8.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 991 failed.

@AndroidBob
Copy link
Collaborator

Build 992 failed.

@AndroidBob
Copy link
Collaborator

Build 999 failed.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

@trOnk12 looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
36b2c2080a1db1cee5ad7bdd148d699e4a02fb36 8090ad5468066fdebe917c53aca549aaf13817b7

Is this intentional?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

@trOnk12 looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
36b2c2080a1db1cee5ad7bdd148d699e4a02fb36 8090ad5468066fdebe917c53aca549aaf13817b7

Is this intentional?

@AndroidBob
Copy link
Collaborator

Build 1003 failed.

@AndroidBob
Copy link
Collaborator

Build 1005 failed.

@AndroidBob
Copy link
Collaborator

Build 1045 failed.

@AndroidBob
Copy link
Collaborator

Build 1047 failed.

@AndroidBob
Copy link
Collaborator

Build 1052 failed.

@AndroidBob
Copy link
Collaborator

Build 1065 failed.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #2079 (05cdfda) into develop (92b79c8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #2079      +/-   ##
=============================================
+ Coverage      39.60%   39.63%   +0.03%     
- Complexity       930      939       +9     
=============================================
  Files            305      305              
  Lines          11262    11262              
  Branches        1506     1506              
=============================================
+ Hits            4460     4464       +4     
+ Misses          6370     6369       -1     
+ Partials         432      429       -3     
Files Changed Coverage Δ
...in/kotlin/com/wire/android/mapper/MessageMapper.kt 66.00% <100.00%> (+4.00%) ⬆️
...me/conversations/info/ConversationInfoViewState.kt 100.00% <100.00%> (ø)
...e/android/ui/home/conversations/model/UIMessage.kt 44.32% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b79c8...05cdfda. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@trOnk12 trOnk12 added this pull request to the merge queue Aug 14, 2023
Merged via the queue into develop with commit 2000815 Aug 14, 2023
12 of 13 checks passed
@trOnk12 trOnk12 deleted the feat/message_status_lifecycle branch August 14, 2023 11:13
@AndroidBob
Copy link
Collaborator

Build 1074 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants