chore: add handling NoNetworkConnection in image loader [WPB-3475] #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…twork_in_image_loader # Conflicts: # kalium
Codecov Report
@@ Coverage Diff @@
## develop #2097 +/- ##
=============================================
+ Coverage 40.31% 40.35% +0.04%
- Complexity 952 956 +4
=============================================
Files 305 305
Lines 11290 11307 +17
Branches 1512 1516 +4
=============================================
+ Hits 4551 4563 +12
- Misses 6302 6307 +5
Partials 437 437
Continue to review full report in Codecov by Sentry.
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 1080 succeeded. The build produced the following APK's: |
saleniuk
requested review from
a team,
typfel,
MohamadJaara,
vitorhugods,
mchenani and
trOnk12
and removed request for
a team
alexandreferris
approved these changes
Aug 16, 2023
mchenani
approved these changes
Aug 16, 2023
…twork_in_image_loader # Conflicts: # kalium
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 1135 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Image loader needs to be adapter to handle
NoNetworkConnectionthat comes as a response from the network module viaGetMessageAssetUseCase.Solutions
Handle
NetworkFailure.NoNetworkConnectioninAssetImageFetcher. Introduce aAssetImageRetryPolicywith three values:RETRY_WHEN_CONNECTED,EXPONENTIAL_RETRY_WHEN_CONNECTED,DO_NOT_RETRY, depending on the result returned by the use case. For "no connection" errors, just retry when there is a connection restored, for other server-related errors, also apply exponential delay (maybe there's a temporary problem on a server side so retrying right away doesn't make sense).Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.