Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: security classification label [WPB-3715] #2104

Merged
merged 17 commits into from
Aug 18, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Aug 16, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • fixed issue that classification label doesn't show when message input field is not open
  • refactored security classification banner to have one single composable with view model where it can be reused in OtherUserProfile, OngoingCall and Conversation Screen.
  • changed structure of showing banner in OngoingCallScreen by adding spacers to show calling options always in center with or without classification banner

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

Test Results

557 tests  +2   556 ✔️ +2   5m 41s ⏱️ -26s
  81 suites +1       1 💤 ±0 
  81 files   +1       0 ±0 

Results for commit 4001e4a. ± Comparison against base commit 37d7257.

♻️ This comment has been updated with latest results.

@Garzas Garzas changed the title fix: security classification label [] fix: security classification label [WPB-3715] Aug 16, 2023
@AndroidBob
Copy link
Collaborator

Build 1119 failed.

@AndroidBob
Copy link
Collaborator

Build 1158 failed.

@AndroidBob
Copy link
Collaborator

Build 1159 failed.

@AndroidBob
Copy link
Collaborator

Build 1160 failed.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #2104 (4001e4a) into develop (37d7257) will decrease coverage by 0.05%.
The diff coverage is 77.77%.

@@              Coverage Diff              @@
##             develop    #2104      +/-   ##
=============================================
- Coverage      40.35%   40.30%   -0.05%     
+ Complexity       956      954       -2     
=============================================
  Files            305      305              
  Lines          11308    11292      -16     
  Branches        1516     1516              
=============================================
- Hits            4563     4551      -12     
+ Misses          6308     6304       -4     
  Partials         437      437              
Files Changed Coverage Δ
.../ui/home/conversations/MessageComposerViewModel.kt 74.05% <ø> (+0.37%) ⬆️
.../ui/home/conversations/MessageComposerViewState.kt 83.33% <ø> (-1.29%) ⬇️
...ndroid/ui/userprofile/self/SelfUserProfileState.kt 0.00% <0.00%> (ø)
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 0.00% <0.00%> (ø)
...in/kotlin/com/wire/android/ui/calling/CallState.kt 100.00% <100.00%> (ø)
.../wire/android/ui/calling/SharedCallingViewModel.kt 66.66% <100.00%> (-0.40%) ⬇️
...me/conversations/info/ConversationInfoViewModel.kt 80.51% <100.00%> (ø)
...me/conversations/info/ConversationInfoViewState.kt 100.00% <100.00%> (ø)
...rsations/messages/ConversationMessagesViewModel.kt 56.79% <100.00%> (ø)
...roid/ui/userprofile/other/OtherUserProfileState.kt 86.48% <100.00%> (-0.36%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37d7257...4001e4a. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1168 succeeded.

The build produced the following APK's:

@Garzas Garzas requested review from a team, gongracr and vitorhugods and removed request for a team August 18, 2023 05:55
@Garzas Garzas enabled auto-merge August 18, 2023 07:44
@Garzas Garzas added this pull request to the merge queue Aug 18, 2023
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 3a65370 Aug 18, 2023
13 of 14 checks passed
@Garzas Garzas deleted the fix/security-classification-label branch August 18, 2023 08:11
@AndroidBob
Copy link
Collaborator

Build 1171 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants