Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: markdown link crash #2116

Merged
merged 2 commits into from
Aug 21, 2023
Merged

fix: markdown link crash #2116

merged 2 commits into from
Aug 21, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:

⚠️ Conflicts during cherry-pick:

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Secured spannable links to not throw IndexOutOfBoundsException

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Aug 18, 2023
@AndroidBob
Copy link
Collaborator

Build 1186 succeeded.

The build produced the following APK's:

@vitorhugods vitorhugods added this pull request to the merge queue Aug 21, 2023
@github-actions
Copy link
Contributor Author

Test Results

572 tests  ±0   571 ✔️ ±0   5m 14s ⏱️ -36s
  83 suites ±0       1 💤 ±0 
  83 files   ±0       0 ❌ ±0 

Results for commit cad7ddc. ± Comparison against base commit 65fc8c7.

@github-actions
Copy link
Contributor Author

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1200 succeeded.

The build produced the following APK's:

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 21, 2023
@Garzas Garzas added this pull request to the merge queue Aug 21, 2023
Merged via the queue into develop with commit 36ff8db Aug 21, 2023
13 checks passed
@Garzas Garzas deleted the fix/markdown-link-crash-cherry-pick branch August 21, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmspzz tmspzz tmspzz approved these changes

@vitorhugods vitorhugods vitorhugods approved these changes

@Garzas Garzas Awaiting requested review from Garzas

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

Assignees

@Garzas Garzas

Labels
cherry-pick PR is cherry-picking changes from another banch size/L
Projects
None yet
Milestone
No milestone
4 participants
@AndroidBob @tmspzz @vitorhugods @Garzas