Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add call to action settings icons (WPB-3065) #2127

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Add icons to settings screen, and small improvements to debug settings, for later work of https://wearezeta.atlassian.net/browse/WPB-351

Needs releases with:

  • GitHub link to other pull request

Attachments (Optional)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Aug 22, 2023
@yamilmedina yamilmedina changed the title fix(rc): call to action settings icons (WPB-3065) fix(dev): call to action settings icons (WPB-3065) Aug 22, 2023
@AndroidBob
Copy link
Collaborator

Build 1222 failed.

@yamilmedina yamilmedina requested review from a team, typfel, gongracr, yamilmedina, vitorhugods, mchenani, alexandreferris, Garzas and ohassine and removed request for a team, typfel, gongracr and yamilmedina August 22, 2023 14:54
@github-actions
Copy link
Contributor Author

github-actions bot commented Aug 22, 2023

Test Results

572 tests  ±0   571 ✔️ ±0   8m 8s ⏱️ -2s
  83 suites ±0       1 💤 ±0 
  83 files   ±0       0 ±0 

Results for commit c481756. ± Comparison against base commit 65457e5.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1223 failed.

@yamilmedina yamilmedina force-pushed the fix/calltoaction-settings-icons-cherry-pick branch from 24aaa20 to 9dff85f Compare August 23, 2023 07:47
@yamilmedina yamilmedina changed the title fix(dev): call to action settings icons (WPB-3065) fix: add call to action settings icons (WPB-3065) Aug 23, 2023
@github-actions
Copy link
Contributor Author

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1226 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina added this pull request to the merge queue Aug 23, 2023
Merged via the queue into develop with commit e8638e5 Aug 23, 2023
14 checks passed
@yamilmedina yamilmedina deleted the fix/calltoaction-settings-icons-cherry-pick branch August 23, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/L
Projects
None yet
4 participants