-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add call to action settings icons (WPB-3065) #2127
Merged
yamilmedina
merged 3 commits into
develop
from
fix/calltoaction-settings-icons-cherry-pick
Aug 23, 2023
Merged
fix: add call to action settings icons (WPB-3065) #2127
yamilmedina
merged 3 commits into
develop
from
fix/calltoaction-settings-icons-cherry-pick
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick
PR is cherry-picking changes from another banch
label
Aug 22, 2023
yamilmedina
changed the title
fix(rc): call to action settings icons (WPB-3065)
fix(dev): call to action settings icons (WPB-3065)
Aug 22, 2023
Build 1222 failed. |
yamilmedina
requested review from
a team,
typfel,
gongracr,
yamilmedina,
vitorhugods,
mchenani,
alexandreferris,
Garzas and
ohassine
and removed request for
a team,
typfel,
gongracr and
yamilmedina
August 22, 2023 14:54
alexandreferris
approved these changes
Aug 22, 2023
Build 1223 failed. |
yamilmedina
force-pushed
the
fix/calltoaction-settings-icons-cherry-pick
branch
from
August 23, 2023 07:47
24aaa20
to
9dff85f
Compare
yamilmedina
changed the title
fix(dev): call to action settings icons (WPB-3065)
fix: add call to action settings icons (WPB-3065)
Aug 23, 2023
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1226 succeeded. The build produced the following APK's: |
saleniuk
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Add icons to settings screen, and small improvements to debug settings, for later work of https://wearezeta.atlassian.net/browse/WPB-351
Needs releases with:
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.