-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(debug): migration progress [WPB-3523] #2128
feat(debug): migration progress [WPB-3523] #2128
Conversation
Codecov Report
@@ Coverage Diff @@
## feat/migration-system-messages #2128 +/- ##
====================================================================
+ Coverage 40.25% 40.31% +0.06%
Complexity 952 952
====================================================================
Files 305 305
Lines 11311 11328 +17
Branches 1515 1516 +1
====================================================================
+ Hits 4553 4567 +14
- Misses 6319 6321 +2
- Partials 439 440 +1
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1229 failed. |
@@ -46,17 +47,24 @@ import com.wire.android.ui.theme.wireColorScheme | |||
@Composable | |||
fun StatusBox( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: since it's now used in multiple places, not only for the statuses, maybe we should rename it to be something more like BadgeBox
? 🤔
modifier = modifier | ||
.fillMaxWidth() | ||
.clip(RoundedCornerShape(dimensions().spacing24x)) // Add rounded corners here | ||
.height(dimensions().spacing24x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: it's missing contentAlignment = Alignment.Center,
and probably this height is too small or the font is a little too big because Text
that's inside is taller than 24.dp, so even if I used contentAlignment = Alignment.Center,
, it wasn't fully centered.
Can you share the link to the design so that we could compare it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share the link to the design so that we could compare it?
There's no design. It's a debugging tool for us only. It won't show in production.
However, it annoys me a bit the fact that it isn't centred 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sharp 👁️
Build 1264 failed. |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.