Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(debug): migration progress [WPB-3523] #2128

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Aug 23, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • MLS migration progress bar in conversation participant screen
  • MLS and PROTEUS badge in participant item

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
before after

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@Garzas Garzas self-assigned this Aug 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

Test Results

546 tests  ±0   545 ✔️ ±0   6m 52s ⏱️ + 1m 17s
  80 suites ±0       1 💤 ±0 
  80 files   ±0       0 ±0 

Results for commit b82534a. ± Comparison against base commit 7e3aba8.

♻️ This comment has been updated with latest results.

@vitorhugods vitorhugods changed the title feat: migration progress [WPB-3523] feat(debug): migration progress [WPB-3523] Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #2128 (b82534a) into feat/migration-system-messages (7e3aba8) will increase coverage by 0.06%.
The diff coverage is 73.91%.

@@                         Coverage Diff                          @@
##             feat/migration-system-messages    #2128      +/-   ##
====================================================================
+ Coverage                             40.25%   40.31%   +0.06%     
  Complexity                              952      952              
====================================================================
  Files                                   305      305              
  Lines                                 11311    11328      +17     
  Branches                               1515     1516       +1     
====================================================================
+ Hits                                   4553     4567      +14     
- Misses                                 6319     6321       +2     
- Partials                                439      440       +1     
Files Changed Coverage Δ
...lin/com/wire/android/mapper/UIParticipantMapper.kt 34.04% <0.00%> (-2.33%) ⬇️
...participants/GroupConversationParticipantsState.kt 95.65% <100.00%> (+4.74%) ⬆️
...participants/model/ConversationParticipantsData.kt 100.00% <100.00%> (ø)
...ations/details/participants/model/UIParticipant.kt 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e3aba8...b82534a. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1229 failed.

@@ -46,17 +47,24 @@ import com.wire.android.ui.theme.wireColorScheme
@Composable
fun StatusBox(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: since it's now used in multiple places, not only for the statuses, maybe we should rename it to be something more like BadgeBox? 🤔

Comment on lines 139 to 142
modifier = modifier
.fillMaxWidth()
.clip(RoundedCornerShape(dimensions().spacing24x)) // Add rounded corners here
.height(dimensions().spacing24x)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: it's missing contentAlignment = Alignment.Center, and probably this height is too small or the font is a little too big because Text that's inside is taller than 24.dp, so even if I used contentAlignment = Alignment.Center,, it wasn't fully centered.

image

Can you share the link to the design so that we could compare it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share the link to the design so that we could compare it?

There's no design. It's a debugging tool for us only. It won't show in production.

However, it annoys me a bit the fact that it isn't centred 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sharp 👁️

@Garzas Garzas requested a review from saleniuk August 25, 2023 08:00
@Garzas Garzas merged commit a4dad88 into feat/migration-system-messages Aug 25, 2023
5 of 7 checks passed
@Garzas Garzas deleted the feat/migration-progress branch August 25, 2023 08:03
@AndroidBob
Copy link
Collaborator

Build 1264 failed.

@typfel typfel mentioned this pull request Oct 15, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants