Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alignment of reactions [AR-3874] #2131

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Reactions options are a bit missaligned and skewed to the start of the screen

Solutions

Use Arrangement.SpaceEvenly to make sure it's all... evenly-spaced.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
image image

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Aug 23, 2023
@AndroidBob
Copy link
Collaborator

Build 1243 succeeded.

The build produced the following APK's:

@vitorhugods vitorhugods added this pull request to the merge queue Aug 24, 2023
@github-actions
Copy link
Contributor Author

Test Results

583 tests  ±0   582 ✔️ ±0   7m 29s ⏱️ -29s
  84 suites ±0       1 💤 ±0 
  84 files   ±0       0 ±0 

Results for commit 625691e. ± Comparison against base commit 87008c6.

@github-actions
Copy link
Contributor Author

APKs built during tests are available here. Scroll down to Artifacts!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 24, 2023
@AndroidBob
Copy link
Collaborator

Build 1260 succeeded.

The build produced the following APK's:

@vitorhugods vitorhugods added this pull request to the merge queue Aug 24, 2023
Merged via the queue into develop with commit ff0283a Aug 24, 2023
13 checks passed
@vitorhugods vitorhugods deleted the fix/reaction-alignment-cherry-pick branch August 24, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/S
Projects
None yet
5 participants