Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(reactions): remove "More coming soon" label [WPB-4328] #2154

Merged
merged 1 commit into from Aug 30, 2023
Merged

chore(reactions): remove "More coming soon" label [WPB-4328] #2154

merged 1 commit into from Aug 30, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:

⚠️ Conflicts during cherry-pick:

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Now that 4.4.0 supports multiple reactions, we don't need the "More coming soon" label.

Solutions

Remove it

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Aug 30, 2023
@AndroidBob
Copy link
Collaborator

Build 408 succeeded.

The build produced the following APK's:

@vitorhugods vitorhugods merged commit 4187ad8 into develop Aug 30, 2023
2 checks passed
@vitorhugods vitorhugods deleted the chore/remove-more-coming-soon-label-cherry-pick branch August 30, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamadJaara MohamadJaara MohamadJaara approved these changes

Assignees

@vitorhugods vitorhugods

Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Milestone
No milestone
3 participants
@AndroidBob @MohamadJaara @vitorhugods