Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move FeatureChanged dialogs to Activity (WPB-3481) #2155

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Aug 30, 2023

What's new in this PR?

Issues

Team Settings changed dialogues are only visible on conversation list.

Causes (Optional)

Feature changes were observed in HomeScreen only, so the dialogs were shown only there.

Solutions

Mode FeatureChanges observation into WireActivity.
Also extracted all the WireActivity dialogs into separate file (there are too many of them already)

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #2155 (d8be252) into develop (31b5e66) will increase coverage by 0.04%.
Report is 9 commits behind head on develop.
The diff coverage is 1.23%.

@@              Coverage Diff              @@
##             develop    #2155      +/-   ##
=============================================
+ Coverage      40.66%   40.71%   +0.04%     
  Complexity       981      981              
=============================================
  Files            310      310              
  Lines          11380    11369      -11     
  Branches        1524     1517       -7     
=============================================
+ Hits            4628     4629       +1     
+ Misses          6313     6300      -13     
- Partials         439      440       +1     
Files Changed Coverage Δ
...android/notification/MessageNotificationManager.kt 0.00% <0.00%> (ø)
...ain/kotlin/com/wire/android/notification/Models.kt 0.00% <0.00%> (ø)
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <0.00%> (ø)
...otlin/com/wire/android/ui/WireActivityViewModel.kt 70.37% <0.00%> (ø)
...re/android/notification/WireNotificationManager.kt 79.31% <40.00%> (-0.30%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4187ad8...d8be252. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

Test Results

583 tests   582 ✔️  7m 3s ⏱️
  84 suites      1 💤
  84 files        0

Results for commit d8be252.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 409 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 423 succeeded.

The build produced the following APK's:

@borichellow borichellow added this pull request to the merge queue Aug 30, 2023
Merged via the queue into develop with commit c0cb4de Aug 30, 2023
13 of 14 checks passed
@borichellow borichellow deleted the fix/move_feature_changed_dialogs_to_activity branch August 30, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants