-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Move FeatureChanged dialogs to Activity (WPB-3481) #2155
fix: Move FeatureChanged dialogs to Activity (WPB-3481) #2155
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2155 +/- ##
=============================================
+ Coverage 40.66% 40.71% +0.04%
Complexity 981 981
=============================================
Files 310 310
Lines 11380 11369 -11
Branches 1524 1517 -7
=============================================
+ Hits 4628 4629 +1
+ Misses 6313 6300 -13
- Partials 439 440 +1
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 409 succeeded. The build produced the following APK's: |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 423 succeeded. The build produced the following APK's: |
What's new in this PR?
Issues
Team Settings changed dialogues are only visible on conversation list.
Causes (Optional)
Feature changes were observed in HomeScreen only, so the dialogs were shown only there.
Solutions
Mode FeatureChanges observation into WireActivity.
Also extracted all the WireActivity dialogs into separate file (there are too many of them already)