Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calling): request audio and BT permission on start, join or accept call (WPB-1809) (WPB-3961) #2160

Merged
merged 5 commits into from Sep 4, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Aug 31, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

This PR aims to request audio/BT permission on every action related to calling(join, answer or start)

If the user decline the permission twice, it will be considered as permanent deny and we will display a dialog containing a button to redirect to app info in settings

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Try to start a call and reject permissions every time it's requested

Attachments (Optional)

Wire 2023-08-31 at 2_50 PM


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, gongracr, yamilmedina, MohamadJaara and Garzas and removed request for a team August 31, 2023 12:55
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

Test Results

590 tests  +6   589 ✔️ +6   7m 5s ⏱️ +25s
  84 suites ±0       1 💤 ±0 
  84 files   ±0       0 ±0 

Results for commit c2d50ac. ± Comparison against base commit 231b06f.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 443 failed.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #2160 (c2d50ac) into develop (231b06f) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #2160      +/-   ##
=============================================
+ Coverage      40.71%   40.79%   +0.07%     
- Complexity       981      990       +9     
=============================================
  Files            310      310              
  Lines          11369    11384      +15     
  Branches        1517     1517              
=============================================
+ Hits            4629     4644      +15     
  Misses          6300     6300              
  Partials         440      440              
Files Changed Coverage Δ
...id/ui/home/conversationslist/ConversationRouter.kt 0.00% <ø> (ø)
...d/util/permission/CallingRecordAudioRequestFlow.kt 0.00% <ø> (ø)
...e/android/ui/calling/incoming/IncomingCallState.kt 100.00% <100.00%> (ø)
...droid/ui/calling/incoming/IncomingCallViewModel.kt 85.89% <100.00%> (+0.76%) ⬆️
...me/conversations/call/ConversationCallViewModel.kt 55.55% <100.00%> (+2.30%) ⬆️
...me/conversations/call/ConversationCallViewState.kt 100.00% <100.00%> (ø)
...ui/home/conversationslist/ConversationListState.kt 94.11% <100.00%> (+0.36%) ⬆️
...ome/conversationslist/ConversationListViewModel.kt 37.66% <100.00%> (+1.09%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 231b06f...c2d50ac. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 445 succeeded.

The build produced the following APK's:

Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 460 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Sep 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2023
@ohassine ohassine added this pull request to the merge queue Sep 4, 2023
Merged via the queue into develop with commit 4a8cabe Sep 4, 2023
13 checks passed
@ohassine ohassine deleted the handle_calling_permissions branch September 4, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants