Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mention highlight [WPB-3507] #2166

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 1, 2023

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Cherry pick from #2164

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Sep 1, 2023
@Garzas Garzas requested review from ohassine, a team, vitorhugods, Garzas, trOnk12 and saleniuk and removed request for a team September 1, 2023 13:13
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #2166 (5b4f69c) into develop (2b85927) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #2166      +/-   ##
=============================================
+ Coverage      40.71%   40.87%   +0.15%     
- Complexity       981      985       +4     
=============================================
  Files            310      310              
  Lines          11369    11371       +2     
  Branches        1517     1518       +1     
=============================================
+ Hits            4629     4648      +19     
+ Misses          6300     6283      -17     
  Partials         440      440              
Files Changed Coverage Δ
.../wire/android/ui/home/messagecomposer/UiMention.kt 0.00% <ø> (ø)
...otlin/com/wire/android/util/QueryMatchExtractor.kt 100.00% <100.00%> (+100.00%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b85927...5b4f69c. Read the comment docs.

@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 1, 2023

Test Results

590 tests  +6   589 ✔️ +6   8m 6s ⏱️ + 1m 9s
  85 suites +1       1 💤 ±0 
  85 files   +1       0 ±0 

Results for commit 5b4f69c. ± Comparison against base commit 2b85927.

@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 1, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 477 succeeded.

The build produced the following APK's:

@Garzas Garzas added this pull request to the merge queue Sep 4, 2023
Merged via the queue into develop with commit cee9f7c Sep 4, 2023
13 checks passed
@Garzas Garzas deleted the fix/mention-highlight-cherry-pick branch September 4, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/L
Projects
None yet
4 participants