fix(RC): adjust transition animations according to the design documentation [WPB-1817] #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-transition-animations-rc
|
Build 497 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
…st-transition-animations-rc
|
Build 506 succeeded. The build produced the following APK's: |
MohamadJaara
approved these changes
Sep 4, 2023
…st-transition-animations-rc
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 520 succeeded. The build produced the following APK's: |
…st-transition-animations-rc
|
Build 535 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 540 succeeded. The build produced the following APK's: |
ohassine
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Copy of #2138
Issues
Current transition animations are not fully aligned with the design documentation.
Solutions
New and existing transition animations and their parameters adjusted to the design documentation, in consultation with Wolfgang. Created
TransitionAnimationTypewith both animation types (slide and pop-up) and set default enter, exit, popEnter and popExit animations for them. Provided more destination styles to be able to set custom transitions for some screens. Basically, every screen having X button instead of back arrow should use the "pop-up" animation. Implemented baseDestinationStyleAnimatedinterface to handle the logic of choosing the right transition animation depending on the recently opened destination, to not mix two transition styles when both destinations involved in the transition use different styles.Attachments (Optional)
transition_animations.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.