fix: enable translations in plurals for failed to add and failed to send messages (WPB-3788) #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamilmedina
requested review from
a team,
alexandreferris,
borichellow,
MohamadJaara,
mchenani,
ohassine and
Garzas
and removed request for
a team
alexandreferris
approved these changes
Sep 4, 2023
ohassine
reviewed
Sep 4, 2023
Comment on lines
+437
to
+441
| if (memberNames.size > 1) { | ||
| R.string.label_system_message_conversation_failed_add_many_members_details | ||
| } else { | ||
| R.string.label_system_message_conversation_failed_add_one_member_details | ||
| } |
There was a problem hiding this comment.
How about using plural xml tag in strings file ?
There was a problem hiding this comment.
Does not fit this case sadly :( since we need to only show when expanded in the UI, but this would require a refactor in SystemMessage component to do it.
I'm doing here the same approach we needed to use for stopping to federate, https://github.com/wireapp/wire-android-reloaded/blob/47891fbe47af5fde2d74f30baaa63aed58de1a6e/app/src/main/res/values/strings.xml#L558-L559
Garzas
approved these changes
Sep 4, 2023
Merged
6 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Sep 4, 2023
…end messages (WPB-3788) (#2170)
|
Build 508 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
We need to be able to properly translate in plurals for other supported languages, ie: German, Spanish, etc.
Solutions
Add plurals versions to strings for failed to add and partial failed to send.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.