Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust message partial delivery failure and assets (WPB-4450) #2180

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 5, 2023

BugWPB-4450 [Android] Image and assets with failed to send produces overlaps in UI

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When a partial failure is displayed the message overlaps the asset (image, asset)

Causes (Optional)

Visual bug, as can not see the message

Solutions

Add Column component as in Text message types for correct rendering.

How to Test

Manually tested in federated environments.

Attachments (Optional)

BEFORE

AFTER


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Sep 5, 2023
@yamilmedina yamilmedina requested review from a team, yamilmedina, alexandreferris, vitorhugods, Garzas and saleniuk and removed request for a team and yamilmedina September 5, 2023 12:27
@AndroidBob
Copy link
Collaborator

Build 573 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina added this pull request to the merge queue Sep 5, 2023
@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 5, 2023

Test Results

599 tests  ±0   598 ✔️ ±0   4m 41s ⏱️ - 3m 48s
  85 suites ±0       1 💤 ±0 
  85 files   ±0       0 ±0 

Results for commit b249a50. ± Comparison against base commit 11e6dbf.

@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 5, 2023

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 1d85bc1 Sep 5, 2023
14 of 15 checks passed
@yamilmedina yamilmedina deleted the fix/adjust-messagefails-and-images-cherry-pick branch September 5, 2023 14:06
@AndroidBob
Copy link
Collaborator

Build 576 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/M
Projects
None yet
5 participants