Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app crash when clicking next on create account screen #2183

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

app crash when clicking next on create account screen

Causes (Optional)

the CreateAccountScren wrap its items in a LazyColumn and when clicking next in the keyboard the password input is not in display (aka not composed) but we do request on focuseChange -> the app crash

Solutions

disable autofill for create account screen since it does not make sense to request saved passwords when creating a new account

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Test Results

556 tests   555 ✔️  37s ⏱️
  78 suites      1 💤
  78 files        0

Results for commit 86c97fe.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara requested review from a team, typfel, borichellow, vitorhugods, Garzas and saleniuk and removed request for a team September 6, 2023 12:28
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 598 succeeded.

The build produced the following APK's:

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fix, just added a small comment.

Copy link
Contributor

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disable autofill for create account screen since it does not make sense to request saved passwords when creating a new account

Really?
I usually use this functionality to add my password to the password manager before finishing the account creation.

Isn't there another way?

@MohamadJaara
Copy link
Member Author

MohamadJaara commented Sep 6, 2023

disable autofill for create account screen since it does not make sense to request saved passwords when creating a new account

Really? I usually use this functionality to add my password to the password manager before finishing the account creation.

Isn't there another way?

@vitorhugods
in our case it is used to suggest auto fill for already stored passwords, and that does not make sense in the context of creating a new account, suggesting to save passwords is not implemented

but with the other changes i did it should work even if we enabled it

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 601 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara merged commit bde454e into release/cycle-4.3 Sep 6, 2023
11 checks passed
@MohamadJaara MohamadJaara deleted the fix/crach-when-requesting-auto-fill branch September 6, 2023 15:41
MohamadJaara added a commit that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants