Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash related to request focus when clicking on last name EditTe… #2191

Conversation

MohamadJaara
Copy link
Member

…xt in CreateAccountDetailsScreen


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

same as #2190 for RC

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Test Results

587 tests   586 ✔️  6m 12s ⏱️
  84 suites      1 💤
  84 files        0

Results for commit 71c1454.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 621 failed.

@MohamadJaara MohamadJaara requested review from a team, typfel, gongracr, mchenani, Garzas and saleniuk and removed request for a team September 7, 2023 15:59
…uest-focus-when-clicking-on-last-name-EditText-in-CreateAccountDetailsScreen
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 632 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara merged commit 9a11262 into release/candidate Sep 7, 2023
13 checks passed
@MohamadJaara MohamadJaara deleted the fix/rc-fix-crash-related-to-request-focus-when-clicking-on-last-name-EditText-in-CreateAccountDetailsScreen branch September 7, 2023 17:42
MohamadJaara added a commit that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants