fix(2fa): login button disabled after verifiction backpress [WPB-3590] #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refined the process of two-factor authentication in LoginEmailViewModel. The loading state and enabled state of the email login are now correctly updated when missing 2FA is detected. This facilitates better user interaction by maintaining appropriate button states during 2FA processing. Also, additional test cases are added to verify the correct behaviour under these changes.
vitorhugods
requested review from
a team,
borichellow,
MohamadJaara,
mchenani,
Garzas and
saleniuk
and removed request for
a team
alexandreferris
approved these changes
Sep 7, 2023
|
APKs built during tests are available here. Scroll down to Artifacts! |
mchenani
approved these changes
Sep 7, 2023
MohamadJaara
approved these changes
Sep 7, 2023
vitorhugods
deleted the
fix/2fa/login-button-disabled-after-verifiction-backpress
branch
6 tasks
|
Build 622 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Login button is disabled after user navigates back from 2FA verification
Causes
loadingstate is not properly reset on 2FA-related failures.Solutions
Properly reset the state and reenable the button.
Testing
Test Coverage
How to Test
See videos below, requires being member of a team that requires 2FA.
Attachments
Before
Faulty.2FA.backbutton.webm
After
Working.2FA.backbutton.webm
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.